[bitnami/mlflow] MLFLOW_S3_ENDPOINT_URL not inject if i dont want to use minio

Alansyf commented 1 month ago

Name and Version

mlflow/1.2.0

What architecture are you using?

None

What steps will reproduce the bug?

it was working fine before and today I am upgrading my mlflow to the latest mlfow 2.13.0.

In my values.yaml I need to set minio to false due to company policy.

minio:
  ## @param minio.enabled Enable/disable MinIO&reg; chart installation
  ## to be used as an objstore for Mlflow
  ##
  enabled: false

But I have my custom s3 host, e.g my company provided s3-compatible host:

externalS3:
  host: "objectstore.xyz.com"
  port: 443
  ...

In this PR , it introduced that i must enable minio otherwise my custom value won't able to inject.

I have to temporary remove the PR introduced condition.

Are you using any custom parameters or values?

No response

What is the expected behavior?

No response

What do you see instead?

NA.

Additional information

No response

javsalgar commented 1 month ago

Hi,

I believe that the condition should be like this

Instead of

{{- if .Values.minio.enabled}}

it should be

{{- if or .Values.minio.enabled .Values.externalS3.host }}

As you spotted the issue. Would you like to submit a PR fixing it?

github-actions[bot] commented 4 weeks ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 3 weeks ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

frittentheke commented 2 weeks ago

@andresbono please kindly reopen. There is a PR open for this.

github-actions[bot] commented 2 hours ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

bitnami / charts