search

bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
8.9k stars 9.16k forks source link

[bitnami/redis] Long release name breaks statefulset pods #27549

Closed kkopachev closed 2 months ago

kkopachev commented 3 months ago

Name and Version

bitnami/redis 19.5.5

What architecture are you using?

None

What steps will reproduce the bug?

helm install aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa oci://registry-1.docker.io/bitnamicharts/redis --set architecture=standalone --set master.persistence.enabled=false

where release name is 41 character long

Are you using any custom parameters or values?

--set architecture=standalone --set master.persistence.enabled=false

What is the expected behavior?

Expect either error on helm install time or release name truncated further to account for longer pod names in statefulset

What do you see instead?

Helm deploys successfully, but pods in replica set fail to start with 

create Pod aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-redis-master-0 in StatefulSet aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-redis-master failed error: 
Pod "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-redis-master-0" is invalid: metadata.labels: Invalid value: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-redis-master-df5fb664f": must be no more than 63 characters

Additional information

No response

fmulero commented 3 months ago

Thanks a lot @kkopachev for using bitnami/charts and sharing your findings.

You right, the redis chart is not truncating the names as other charts do (For instance appsmith uses this helper to avoid issues with the names). Would you like to contribute by creating a PR to solve the issue? The Bitnami team will be happy to review it and provide feedback. Here you can find the contributing guidelines.

github-actions[bot] commented 2 months ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 2 months ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.