bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
8.81k stars 9.1k forks source link

[bitnami/redis] chart enables AOF even if persistence = false #28132

Closed fcbry closed 2 weeks ago

fcbry commented 1 month ago

Name and Version

bitnami/redis 19.5.2

What architecture are you using?

amd64

What steps will reproduce the bug?

The persistence enabled: false configuration is ignored, at least on the master node (we don't use the replica). Here's our helmfile configuration below. I had to add the commonConfiguration block to disable AOF files being writen ( for our use case we don't want to touch the disk).

    chart: bitnami/redis
    version: 19.5.2
    inherit:
      - template: default
    values:
      - ./values/redis.yaml
      - nameOverride: meatatwork-web
      - metrics:
          enabled: true
      # we have to add this configuration to prevent AOF file (appendonly: no) otherwise that persistence mechanism is activated
      - commonConfiguration:
          appendonly: 'no'
          save: ""
      - master:
          kind: Deployment
          persistence:
            enabled: false
          resources:
            limits:
              memory: 512Mi
              cpu: 0.25
            requests:
              memory: 64Mi
              cpu: 0.01

Are you using any custom parameters or values?

No response

What is the expected behavior?

No response

What do you see instead?

│ 1:M 17 Jul 2024 08:21:57.552 * RDB age 497 seconds                                                                                                                                                                          ││ 1:M 17 Jul 2024 08:21:57.552 * RDB memory usage when created 19.26 Mb                                                                                                                                                       ││ 1:M 17 Jul 2024 08:21:57.552 * RDB is base AOF                                                                                                                                                                              ││ 1:M 17 Jul 2024 08:21:57.571 * Done loading RDB, keys loaded: 804, keys expired: 0.                                                                                                                                         ││ 1:M 17 Jul 2024 08:21:57.571 * DB loaded from base file appendonly.aof.35.base.rdb: 0.019 seconds                                                                                                                           ││ 1:M 17 Jul 2024 08:21:57.612 * DB loaded from incr file appendonly.aof.35.incr.aof: 0.041 seconds                                                                                                                           ││ 1:M 17 Jul 2024 08:21:57.612 * DB loaded from append only file: 0.060 seconds                                                                                                                                               ││ 1:M 17 Jul 2024 08:21:57.612 * Opening AOF incr file appendonly.aof.35.incr.aof on server start                                                                                                                             ││ 1:M 17 Jul 2024 08:21:57.612 * Ready to accept connections tcp                                                                                                                                                              ││ 1:M 17 Jul 2024 08:28:29.762 * Starting automatic rewriting of AOF on 2438% growth                                                                                                                                          ││ 1:M 17 Jul 2024 08:28:29.763 * Creating AOF incr file appendonly.aof.36.incr.aof on background rewrite                                                                                                                      ││ 1:M 17 Jul 2024 08:28:29.765 * Background append only file rewriting started by pid 1649                                                                                                                                    ││ 1649:C 17 Jul 2024 08:28:29.810 * Successfully created the temporary AOF base file temp-rewriteaof-bg-1649.aof                                                                                                              ││ 1649:C 17 Jul 2024 08:28:29.814 * Fork CoW for AOF rewrite: current 1 MB, peak 1 MB, average 1 MB                                                                                                                           ││ 1:M 17 Jul 2024 08:28:29.867 * Background AOF rewrite terminated with success                                                                                                                                               ││ 1:M 17 Jul 2024 08:28:29.867 * Successfully renamed the temporary AOF base file temp-rewriteaof-bg-1649.aof into appendonly.aof.36.base.rdb                                                                                 ││ 1:M 17 Jul 2024 08:28:29.868 * Removing the history file appendonly.aof.35.incr.aof in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:28:29.868 * Removing the history file appendonly.aof.35.base.rdb in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:28:29.869 * Background AOF rewrite finished successfully                                                                                                                                                 ││ 1:M 17 Jul 2024 08:31:21.998 * Starting automatic rewriting of AOF on 2041% growth                                                                                                                                          ││ 1:M 17 Jul 2024 08:31:21.999 * Creating AOF incr file appendonly.aof.37.incr.aof on background rewrite                                                                                                                      ││ 1:M 17 Jul 2024 08:31:22.001 * Background append only file rewriting started by pid 2423                                                                                                                                    ││ 2423:C 17 Jul 2024 08:31:22.046 * Successfully created the temporary AOF base file temp-rewriteaof-bg-2423.aof                                                                                                              ││ 2423:C 17 Jul 2024 08:31:22.050 * Fork CoW for AOF rewrite: current 1 MB, peak 1 MB, average 1 MB                                                                                                                           ││ 1:M 17 Jul 2024 08:31:22.102 * Background AOF rewrite terminated with success                                                                                                                                               ││ 1:M 17 Jul 2024 08:31:22.102 * Successfully renamed the temporary AOF base file temp-rewriteaof-bg-2423.aof into appendonly.aof.37.base.rdb                                                                                 ││ 1:M 17 Jul 2024 08:31:22.103 * Removing the history file appendonly.aof.36.incr.aof in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:31:22.103 * Removing the history file appendonly.aof.36.base.rdb in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:31:22.103 * Background AOF rewrite finished successfully                                                                                                                                                 ││ 1:M 17 Jul 2024 08:57:40.856 * Starting automatic rewriting of AOF on 2063% growth                                                                                                                                          ││ 1:M 17 Jul 2024 08:57:40.857 * Creating AOF incr file appendonly.aof.38.incr.aof on background rewrite                                                                                                                      ││ 1:M 17 Jul 2024 08:57:40.859 * Background append only file rewriting started by pid 9378                                                                                                                                    ││ 9378:C 17 Jul 2024 08:57:40.879 * Successfully created the temporary AOF base file temp-rewriteaof-bg-9378.aof                                                                                                              ││ 9378:C 17 Jul 2024 08:57:40.885 * Fork CoW for AOF rewrite: current 1 MB, peak 1 MB, average 1 MB                                                                                                                           ││ 1:M 17 Jul 2024 08:57:40.960 * Background AOF rewrite terminated with success                                                                                                                                               ││ 1:M 17 Jul 2024 08:57:40.960 * Successfully renamed the temporary AOF base file temp-rewriteaof-bg-9378.aof into appendonly.aof.38.base.rdb                                                                                 ││ 1:M 17 Jul 2024 08:57:40.961 * Removing the history file appendonly.aof.37.incr.aof in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:57:40.961 * Removing the history file appendonly.aof.37.base.rdb in the background                                                                                                                       ││ 1:M 17 Jul 2024 08:57:40.961 * Background AOF rewrite finished successfully                                                                                                                                                 ││                                                                                           **

Additional information

No response

jotamartos commented 1 month ago

That persistence parameter is meant to persist the Redis' data directory

https://github.com/bitnami/charts/tree/main/bitnami/redis#persistence

If you want to disable AOF persistence in Redis, you can use this env var

https://github.com/bitnami/containers/tree/main/bitnami/redis#disabling-aof-persistence

github-actions[bot] commented 3 weeks ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 2 weeks ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.