bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
8.81k stars 9.1k forks source link

[bitnami/spring-cloud-dataflow] Adding annotations to stream deployment #28155

Closed dadacom379 closed 1 week ago

dadacom379 commented 1 month ago

Name and Version

bitnami/spring-cloud-dataflow 30.0.0

What is the problem this feature will solve?

At the moment it is not possible to add annotations to a deployment. In my example trying to put in place a Kubernetes reloader when a configMap or secret is changing

What is the feature you are proposing to solve the problem?

Is it possible to add a feature like the existing one?

deployer..kubernetes.job-annotations=reloader.stakater.com/auto:"true" deployer..kubernetes.pod-annotations=reloader.stakater.com/auto:"true" deployer..kubernetes.service-annotations=reloader.stakater.com/auto:"true" Like a configuration that could be deployer..kubernetes.deployment-annotations=reloader.stakater.com/auto:"true"

Then when a injected configMap or secret change the deployment restart

image

?

What alternatives have you considered?

At this time the alternative was to execute a Kubectl command

javsalgar commented 1 month ago

Hi!

In other charts we have the deploymentAnnotations or statefulsetAnnotations value depending on the application. Would you like to submit a PR adding support for this value?

github-actions[bot] commented 1 month ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

dadacom379 commented 1 month ago

Im on holiday ass hold

Le sam. 3 août 2024, 21 h 27, github-actions[bot] @.***> a écrit :

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

— Reply to this email directly, view it on GitHub https://github.com/bitnami/charts/issues/28155#issuecomment-2267231657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFFPTV7N2YT6D7TSMOKFWTZPV7RBAVCNFSM6AAAAABLCREEQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGIZTCNRVG4 . You are receiving this because you authored the thread.Message ID: @.***>

github-actions[bot] commented 2 weeks ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 1 week ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.