search

bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
8.82k stars 9.12k forks source link

[bitnami/external-dns] External dns rfc2136 zone cannot supply more than 2 zones. #28645

Closed Jeremy-Boyle closed 2 weeks ago

Jeremy-Boyle commented 1 month ago

Name and Version

bitnami/external-dns 8.3.3

What is the problem this feature will solve?

Currently the helm template only allows for a single zone, however external-dns can support more than one zone by adding extra argument variables similar to how the domain filter works.

Currently the only way to add another zone is to add it with 

extraArgs:
  rfc2136-zone: extra-zone.com

However since this is a map and not a array it would only be able to support one additional zone.

This will support more than one zone, however, due to the limitations there might be additional providers that allow multiple arguments that cannot be set due to how extraArgs works. Need feedback if this should be changed to how most other bitnami charts do it via. My recommendation is that this should be changed from a map to a array to be inline with other charts to reduce a dependency when arguments are added that support multiple flags. 

extraArgs: []

This fix will change the value 

rfc2136:
  zone: ""

to

rfc2136:
  zones: []

What is the feature you are proposing to solve the problem?

This will change the default values file to support more than two zones.

And discuss if changing to extraArgs: [] makes sense

What alternatives have you considered?

The following can work for another zone, another option is manually editing the template and maintaining yourself.

extraArgs:
  rfc2136-zone: extra-zone.com
javsalgar commented 1 month ago

Hi,

I agree that using an array would make more sense to allow this kind of scenarios. I will forward it to the team but I cannot guarantee an ETA. Would you like to submit a PR adding support for extraArgs as an array? (without breaking backwards compatibility)

javsalgar commented 1 month ago

Thank you so much for the PR!

github-actions[bot] commented 2 weeks ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] commented 2 weeks ago

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.