bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
8.85k stars 9.14k forks source link

[bitnami/thanos] Thanos ruler don't support TLS on grpc #29458

Open mcantinqc opened 5 days ago

mcantinqc commented 5 days ago

Name and Version

thanos 0.36.1

What architecture are you using?

amd64

What steps will reproduce the bug?

The querier can be configured to use TLS for GRPC client connections by adding the following configuration:

query:
  enabled: true
  grpc:
    client:
      tls:
        enabled: true
        autoGenerated: true

This configuration forces the querier to use TLS when calling GRPC endpoints. However, there is currently no way to activate a similar TLS configuration for the ruler component. For comparison, the storegateway component allows TLS configuration for its GRPC server using the following settings:

storegateway:
  enabled: true
  grpc:
    server:
      tls:
        enabled: true
        autoGenerated: true

The issue is that we need a way to enable TLS for GRPC connections on the ruler component, similar to how it's implemented for the querier and storegateway.

Are you using any custom parameters or values?

No response

What is the expected behavior?

GRPC TLS setup for ruler like for storegateway.

What do you see instead?

dialing connection: context deadline exceeded: connection error: desc = \"transport: authentication handshake failed: tls: first record does not look like a TLS handshake

Additional information

Arguments like grpc-server-tls-cert, grpc-server-tls-client-ca and grpc-server-tls-key are fully supported by Thanos ruler : https://thanos.io/tip/components/rule.md/#flags.

javsalgar commented 5 days ago

Hi!

Thank you so much for the feature request. I will forward it to the team but as it is not a critical feature we cannot guarantee an ETA. If you want to speed up the process, you can submit a PR updating the args section of the Ruler statefulset

https://github.com/bitnami/charts/blob/089d15f59f6345ab24ee2f17cf6f740a5c8ca808/bitnami/thanos/templates/ruler/statefulset.yaml#L121