Open BWagenerGenerali opened 1 week ago
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.
Feel free to reach out if you have any questions or need assistance with the signing process.
Hi @carrodher,
it seems I was missing a newline before the sign-off section. It should be fixed now.
Description of the change
Currently the PodDisruptionBudget in the sealed-secret chart is deployed to the release namespace. This however, is not necessarily the namespace the rest of the sealed-secrets manifests are deployed to (i.e. due to
.Values.namespaceOverride
being set).That leads to a violated PodDisruptionBudget in the release namespace, as the pods it references are deployed to a different namespace.
This PR updates the namespace field in the PDB to have the same value as for example the deployment it references:
Benefits
Setting
.Values.namespaceOverride
no longer breaks the PDB.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.