bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
9.04k stars 9.22k forks source link

Fix Sentinel PodDisruptionBudget condition #30482

Open tristan-ludlow opened 6 days ago

tristan-ludlow commented 6 days ago

Name and Version

bitnami/valkey

What architecture are you using?

amd64

What steps will reproduce the bug?

When the valkey chart is installed with the default values file and a disabled Sentinel, the Pdb for the Sentinel still gets created. I believe it is the same problem that requires the same fix applied for Redis here:

https://github.com/bitnami/charts/pull/27080

The condition on line 6 of bitnami/valkey/templates/sentinel/pdb.yaml needs to be reversed:

{{- if and (eq .Values.architecture "replication") (not .Values.sentinel.enabled) .Values.replica.pdb.create }}

What is the expected behavior?

Stop creating the unnecessary PDB when sentinel is not enabled.

What do you see instead?

A useless PDB gets created for sentinel when sentinel itself is disabled.

carrodher commented 4 days ago

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.