bitnami / charts

Bitnami Helm Charts
https://bitnami.com
Other
9.04k stars 9.22k forks source link

adding label for umbrella chart in case redis chart is being used as dependency #30491

Open ankitsahuknit opened 4 days ago

ankitsahuknit commented 4 days ago

Description of the change

This change will provide flexibility to add labels where user will consume redis chart as dependency

Benefits

For any organization who is consuming redis chart as dependency would be able to have their own chart and version as label

Possible drawbacks

Applicable issues

Additional information

Checklist

carrodher commented 2 days ago

Thank you for your PR! I wonder if you could use commonLabels for this purpose. I'm not sure if there’s a standard label for this (perhaps kubernetes.io/part-of), but it looks like helm.sh/umbrellaChart doesn’t exist.

ankitsahuknit commented 19 hours ago

Thank you for your PR! I wonder if you could use commonLabels for this purpose. I'm not sure if there’s a standard label for this (perhaps kubernetes.io/part-of), but it looks like helm.sh/umbrellaChart doesn’t exist.

I believe, we can add some custom labels as per use cases. If anyone using redis bitnami chart as depednecy there is no provision that he/she can label their chart version in redis deployment