search

bitnami / containers

Bitnami container images
https://bitnami.com
Other
3.45k stars 4.92k forks source link

Enable setting innodb_compression_algorithm to lzma #46798

Open jerrac opened 1 year ago

jerrac commented 1 year ago

Name and Version

bitnami/mariadb-galera:10

What is the problem this feature will solve?

It will allow those who wish to save on disk space via the lzma compression option to do so.

What is the feature you are proposing to solve the problem?

Add the lzma plugin to the Docker image. I'm not sure how, though. I think you compile mariadb elsewhere and the add it to the image from there.

What alternatives have you considered?

I tried to install the plugin via apt in a wrapper image, but there is no package for it, and I'm pretty sure it would have been for the 10.5 version of mariadb. Not the 10.9 version you put in the image.

corico44 commented 1 year ago

Hello @jerrac,

We agree that this would be a good addition to the asset, would you be open to contributing this change via a PR? We'd be glad to review and help with the release.

jerrac commented 1 year ago

I wouldn't mind trying to do so. But I'm not sure where to begin.

From https://github.com/bitnami/containers/blob/d8c4ce1f6e2d79413a981c49141dd6c1f43b935d/bitnami/mariadb-galera/11.0/debian-11/Dockerfile#L27 I think you have a separate process somewhere that either compiles MariaDB, or downloads it to make it available on downloads.bitnami.com.

Is there a way to hook into that process to add the lzma stuff? I didn't find any signs that you have that code up on github.

github-actions[bot] commented 1 year ago

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

corico44 commented 1 year ago

Hi @jerrac, I have opened a task internally to investigate further how to apply this change. Any progress will be notified in this issue. Thank you very much for the contribution!