Update DaemonSet, Deployment, StatefulSet and Ingress due to API deprecations

bitnami / kube-libsonnet

Bitnami's jsonnet library for building Kubernetes manifests

https://bitnami.com

Apache License 2.0

172 stars 49 forks source link

Update DaemonSet, Deployment, StatefulSet and Ingress due to API deprecations #22

Closed drzero42 closed 5 years ago

drzero42 commented 5 years ago

kube-libsonnet currently creates DaemonSets, Deployments and StatefulSets with the apigroup apps/v1beta2. According to https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ with Kubernetes 1.16 those API objects will no longer be served from anything but apps/v1. From Kubernetes 1.18, Ingress will no longer be available in the extensions/v1beta1 group. Ingress should be update to use the networking.k8s.io/v1beta1 group. Kube-libsonnet should be updated to reflect these changes.

jjo commented 5 years ago

Thanks @drzero42 for the heads up, excerpting https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/:

NetworkPolicy: will no longer be served from extensions/v1beta1 in v1.16.
- Migrate to the networking.k8s.io/v1 API, available since v1.8. Existing persisted data can be retrieved/updated via the networking.k8s.io/v1 API.
PodSecurityPolicy: will no longer be served from extensions/v1beta1 in v1.16.
- Migrate to the policy/v1beta1 API, available since v1.10. Existing persisted data can be retrieved/updated via the policy/v1beta1 API.
DaemonSet, Deployment, StatefulSet, and ReplicaSet: will no longer be served from extensions/v1beta1, apps/v1beta1, or apps/v1beta2 in v1.16.
- Migrate to the apps/v1 API, available since v1.9. Existing persisted data can be retrieved/updated via the apps/v1 API.
Ingress: will no longer be served from extensions/v1beta1 in v1.18.
- Migrate to the networking.k8s.io/v1beta1 API. Existing persisted data can be retrieved/updated via the networking.k8s.io/v1beta1 API.

jjo commented 5 years ago

FYI #23 fixed some, #27 will complete the fixes (adding Ingress).

jjo commented 5 years ago

Fixed by #23 and #27.

drzero42 commented 5 years ago

Actually, #27 broke things for even fairly current clusters. The networking.k8s.io/v1beta1 apigroup is not available until Kubernetes 1.14. I have GKE clusters still running 1.13, which complain that there is no such apigroup networking.k8s.io/v1beta1. According to the blog post about deprecations, the extensions/v1beta1 apigroup is not going completely away until Kubernetes 1.20, so maybe we should stick with that until everybody can reasonably be expected to have upgraded to at least v1.14? :)

jjo commented 5 years ago

Actually, #27 broke things for even fairly current clusters....

Thanks for reporting back, rolling back Ingress at #29 while also adding some e2e testing coverage (via kubecfg validate).

jjo commented 5 years ago

@drzero42: FYI Ingress rollback committed at #29 (w/added travis-ci e2e coverage).