Fixed missing `storageClassName` field in PersistentVolumeClaim's `spec`

[irizzant]

Fix #25

As reported in the official Kubernetes docs:

A PV can have a class, which is specified by setting the storageClassName attribute to the name of a StorageClass. A PV of a particular class can only be bound to PVCs requesting that class. A PV with no storageClassName has no class and can only be bound to PVCs that request no particular class.

In the past, the annotation volume.beta.kubernetes.io/storage-class was used instead of the storageClassName attribute. This annotation is still working, however it will become fully deprecated in a future Kubernetes release

[jjo]

Thanks @irizzant for the PR, could you please add a comment there pointing to https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class ? Mentions both: annotation and actual field, former to be deprecated in a future release.

[irizzant]

Hi @jjo , I updated the PR. I'd also like to point out that currently minikube 1.3.1 (Kubernetes v1.15.2) does not work with the annotation.

[jjo]

Hi @jjo , I updated the PR. I'd also like to point out that currently minikube 1.3.1 (Kubernetes v1.15.2) does not work with the annotation.

Can you please double check ?, don't see it in this PR

[jjo]

Hi @jjo , I updated the PR. I'd also like to point out that currently minikube 1.3.1 (Kubernetes v1.15.2) does not work with the annotation.

Also note checks are failing on lint, please run: make fix-lint

[irizzant]

Hi @jjo , the checks are ok now.

Hi @jjo , I updated the PR. I'd also like to point out that currently minikube 1.3.1 (Kubernetes v1.15.2) does not work with the annotation.

Can you please double check ?, don't see it in this PR

I put the references to official Kubernetes docs in the PR header, see attached:

[irizzant]

LGTM, thanks much for the fix!

My pleasure, thank you