Closed jjo closed 4 years ago
looks good to me, I'm now wondering if this label:
"kubernetes.io/tls-acme": "true",
is still supported or was deprecated by certt-manager. Need to check the docs, but I recall something around it.In any case, lgtm
vgood point, just verbatim copied from kubeprod upstream, so at least for its setup and cert-manager versions it's working ok.
kube.libsonnet
: few bits here&there, notable addingname
field to svc portsutils.libsonnet
: copied verbatim and added unittests