search

bitnami / kube-libsonnet

Bitnami's jsonnet library for building Kubernetes manifests
https://bitnami.com
Apache License 2.0
172 stars 49 forks source link

add imagePullSecrets "dockerhub-dockerconfig" to SAs #52

Closed jbianquetti-nami closed 2 years ago

jbianquetti-nami commented 4 years ago

As part of the authenticated pull from DockerHub, we'll be setting the "dockerhub-dockerconfig" imagePullSecret as default for 'bitnami.libsonnet' library.

Any project using this library can assign this imagePullSecret to a ServiceAccount by using

nginx_ingress_service_account: bitnami.ServiceAccount("nginx-ingress")

This snippet will be added to the SA:

   "imagePullSecrets": {
      "name": "dockerhub-dockerconfig"
   },

The secret will be only available on those clusters who make use of ClusterSecrets, which replicates the source secret to desired namespaces in the cluster.

KOPS managed clusters doesn't need any imagePullSecret definition since use a Docker config in the nodes, so the pull is authenticated out of K8s

jbianquetti-nami commented 3 years ago

I think this it's not needed anymore if we include imagePullSecret-patcher or any other software. Putting it in the freezer