bitnami / kube-libsonnet

Bitnami's jsonnet library for building Kubernetes manifests
https://bitnami.com
Apache License 2.0
172 stars 49 forks source link

[jjo] support Kubernetes v1.22+ apiVersions deprecations (round2) #63

Closed jjo closed 3 years ago

jjo commented 3 years ago

Fixes #60, after also fixing PR #61 issues.

Support Kubernetes v1.22+ apiVersions deprecations, notably:

Other changes:

jjo commented 3 years ago

@dbarranco @jbianquetti-nami round#2 for this one :), should fix #61 issues. Do note btw using pathType: ImplementationSpecific for bitnami.libsonnet ingresses, lemme know if you'd prefer Prefix there instead. Thanks! 🤗

dbarranco commented 3 years ago

wow, that was QUICK!

Thanks a lot for the PR. Wrt:

pathType: ImplementationSpecific -> I'm happy with it, I agree this is the most generic one and I think we should go for it.


Will test this as soon as I have a chance and will let you know :) Thanks again!

jjo commented 3 years ago

I think it looks good to me.

Will test + merge next Monday!

Thanks cumpa!, pls send a big hug to the Bitnami team from me <3

dbarranco commented 3 years ago

Ran some local tests, everything works flawless 👍

Thanks a lot!

jjo commented 3 years ago

Ran some local tests, everything works flawless 👍

Thanks a lot!

Thanks!, Could you please push a v1.19.0 tag on the current HEAD ? Recall the tagging ~loosely reflecting the minimum required Kubernetes <major>.<minor>.

dbarranco commented 3 years ago

https://github.com/bitnami-labs/kube-libsonnet/releases/tag/v1.19.0 :)