Closed jjo closed 3 years ago
@dbarranco @jbianquetti-nami round#2 for this one :), should fix #61 issues.
Do note btw using pathType: ImplementationSpecific
for bitnami.libsonnet
ingresses, lemme know if you'd prefer Prefix
there instead.
Thanks! 🤗
wow, that was QUICK!
Thanks a lot for the PR. Wrt:
pathType: ImplementationSpecific
-> I'm happy with it, I agree this is the most generic one and I think we should go for it.
Will test this as soon as I have a chance and will let you know :) Thanks again!
I think it looks good to me.
Will test + merge next Monday!
Thanks cumpa!, pls send a big hug to the Bitnami team from me <3
Ran some local tests, everything works flawless 👍
Thanks a lot!
Ran some local tests, everything works flawless 👍
Thanks a lot!
Thanks!,
Could you please push a v1.19.0
tag on the current HEAD ?
Recall the tagging ~loosely reflecting the minimum required Kubernetes <major>.<minor>
.
Fixes #60, after also fixing PR #61 issues.
Support Kubernetes v1.22+ apiVersions deprecations, notably:
Ingress
:apiVersion: networking.k8s.io/v1
service
field to eachpath
(previouslyserviceName
andservicePort
)bitnami.libsonnet
: usepathType: ImplementationSpecific
, which seems to be the most generic onename
andnumber
mutual exclusion logic and test casesCustomResourceDefinition
:apiVersion: apiextensions.k8s.io/v1
versions
map with sensible defaults, includingspec
field, as commonly used fro CRsOther changes:
tests/Makefile
: support (only) v1.19+tests/init-kube.jsonnet
: CRD tweaks