search

bitnami / kube-libsonnet

Bitnami's jsonnet library for building Kubernetes manifests
https://bitnami.com
Apache License 2.0
172 stars 49 forks source link

jsonnetfmt -i kube*.libsonnet #68

Open davidquarles opened 3 years ago

davidquarles commented 3 years ago

I've used this library extensively at my current and previous gigs and can't thank you all enough for the work! We currently have our own private fork with a handful of additions that I intend to submit here but am as of now just trying to reconcile the cosmetic changes introduced by a basic invocation of jsonnetfmt / the vim-jsonnet plugin, so that we can more easily see the forest through the trees. This is, for the most part, just a switch from double quotes to single quotes (the default).

Is this desirable? I've only touched the files that we actually rely on downstream to minimize the footprint of this PR, but I can easily loop in all of .sonnet, too.

Thanks!

jjo commented 3 years ago

As always it's a matter of style :), also enforced in tests/Makefile via JSONNET_FMT settings there. Agree that we should switch to jsonnetfmt stock style, note that indeed tests will need to be fixed.