bitnami / kube-libsonnet

Bitnami's jsonnet library for building Kubernetes manifests
https://bitnami.com
Apache License 2.0
174 stars 50 forks source link

Deployment: remove replicas=1 #74

Closed chengchengmu closed 2 years ago

chengchengmu commented 2 years ago

Description

This PR removes the replicas: 1 inside the Deployment object.

Motivation

For Horizontal Pod Autoscaler to work properly with gitops systems such as ArgoCD, FluxCD, Deployment objects shouldnt' have replicas set. The default replicas is 1 so this is safe to be removed. Also it appears that it is not easy to remove a field in jsonnet once it is set, so it is better to just not set it.

References

chengchengmu commented 2 years ago

Thanks @jjo !

@jbianquetti-nami do you mind taking a look at this tiny PR when you get a chance ?