Learn Angular (Review) - Githubissues

Global

[ ] Suggestion: The section How to Verify Your Solution is Correct I think should be after the Solution section
[ ] Suggestion: For all sections we should have an image after each solution to give the user a visual representation of how each completed section should appear. Similar to what sections like Adding Routing have the show visual representation to aid users.
[ ] Suggestion: In various sections the order seems to be off where the sub-section What You Need to Know up until sub-section (x) right before the Solution section should be swapped and placed before How to Verify Your Solution is Correct --> Noted Sections [Adding Routing, Creating Navigation, Use Restaurant API data, City & State Options, Filter Cities by State, Filter Restaurants by City, Optional: Declarative State, Building the Order Form, Order Service, Order History Component]
[ ] Suggestion: Creating an npm script that runs npm run start and npm run api to limit the amount of terminals a user needs to have open

Learn Angular

[x] Fix/Change: Change declartively to declaratively

Generate an App

[x] Fix/Change: Within the passage This file is the root module for our app. Every Angular app has at least one module that determines how to compile and launch and app. It use --> Change the and to an

Creating Components

[ ] Suggestion: Right next to the run text we should consider putting a passage that says "if you haven't already run this command ng g component home in the CLI please run..." the reason being is if someone ran this command ng g component home within the previous section Generate Components then they'll get this error message which could confuse someone to think they've done something wrong.
[x] Fix/Change: Reminder: The markup that should be written out for each restaurant can be found in the exercise description. The url for exercise description. doesn't take you to the desired section.

Creating Pipes

[ ] Suggestion: Within the setup I see a bit of redundancy with the command ng g pipe imageUrl because before hand we already have run the command in the section How to Generate a Pipe via the CLI so perhaps maybe we can remove the section How to Generate a Pipe via the CLI in favor of letting users run the command for the first time in the Setup section.

Adding Routing

[x] Fix/Change: Within the paragraph --> , which handles routing to a component based on a url, was added to our src/app/app.component.html file when we first generated our app and answered yes to the routing question. But since that time, we added components to that view. Lets remove those components because will handle showing those components going forward. --> Change Lets to Let's

Creating Navigation

[ ] Suggestion: Consider revising this portion --> In reusable components we'll often want to dynamically create paths based on a piece of datas unique property values.

Use Restaurant API data

[ ] Suggestion: Remind users to run the npm run api command in a second terminal and keep it open and running to have continual access to the data from the API

City & State Options

[x] Fix/Change: Right below: Update src/app/app.module.ts to import reactiveForms in the root app module: remove the update highlight from line 23 in the code block.

Filter Cities by State

[ ] Bug: When you scroll an get to Problem 2: Write Service Methods to Get States and Cities from API the TOC on the right hand side seems to be mis-aligned with the main scrolling content. View Bug

Building the Order Form

[x] Fix/Change: Within the passage This time, our form will require validation. Here's an example of a form with form controls with different validation, and one thats value is set to an array. --> Change thats to that's
[x] Fix/Change: Within the sub-section P3: What You Need to Know under Component Interaction The code example within this section had a few bugs that caused it not to work so I suggest that we update the code sample below which fixes the error and makes use of @Input's other features.
[ ] Suggestion: Within the sub-section P3: What You Need to Know under Component Interaction I think we should remove the link to @Output docs since we don;t make use of it within the code example unless we intend to add an example of how it works.
```
class ChildComponent {
// Removed --> @Input() myParent: string;
@Input() parentName: string;
@Input('otherName') parentName: string = 'Sandy';
constructor() {
}
}
```

@Component({ selector: 'my-app', template: `

//Remove --> <my-child [parentName]="momName"> ` }) class AppComponent { // Remove --> public momName: string = 'Sandy' constructor() { } }



- [x] **Fix/Change:** Within the sub-section **Control Value Accessor** add `✏️ Update` next to: **src/app/order/menu-items.component.ts**

## Order Service
- [ ] **Bug** When applying the code from the `P1: Solution` I get this error `ERROR in src/app/order/order.component.ts(59,36): error TS2339: Property '_id' does not exist on type 'Restaurant'.`

## Order History Component
- [ ] **Bug:** When I run `npm run test` for `P1` I see errors still. [View Bug](http://recordit.co/erP1ybk5fk) 

## Real Time Connections
- [ ] **Bug:** When I update **src/app/order/history.component.ts** with the code beneath **Listen to Socket Events** I get this [error](http://recordit.co/sn0WHPoGdo). Update the test for this section

bitovi / academy

Learn Angular (Review) #161

Global

Learn Angular

Generate an App

Creating Components

Creating Pipes

Adding Routing

Creating Navigation

Use Restaurant API data

City & State Options

Filter Cities by State

Building the Order Form