Closed chasenlehara closed 1 month ago
Test is failing when running benchmark. It pass successfully without benchmark
Test is failing when running benchmark. It pass successfully without benchmark
Interesting, I ran into this too at parallel limits 9+ (my Mac as 10 cores). I don’t think this matters for merging it in because I left the benchmark code mainly as a reference for doing something similar in the future.
This improves the time it takes to run the exercise solution tests by running them in parallel.
Below are the results of multiple test runs in GitHub and on a MacBook Pro. It looks like about three tests running in parallel is optimal in both environments, so the
test
script will max out at running three tests at a time.First run in GitHub CI:
Second run (after changing the max limit after realizing the first run will be slower while priming the npm cache):
First run on a MacBook Pro:
Second run: