Closed lkodai closed 8 years ago
@lkodai this looks great!
Here's some things that I spotted:
<img width="591" alt="screen shot 2016-05-13 at 8 58 32 am" src="https://cloud.githubusercontent.com/assets
vs
For example:
<h3>
seems to high right now. Adjusting it to line-height: normal
seems to work well:
vs
@lkodai one more that I spotted.
But I'm wondering if we should just point to examples/styles/variables.less.html instead, as we do on the homepage CTA. Thoughts?
Hey Adri,
Phew! So I'm leaving any demo fixes for another branch and there are enough working demos to serve purposes for now I think. This PR is already a gigantic change-storm afterall. But I went through your other comments for the better:
New H3 and H4 don't look like giant links anymore. (And main content links have an underline on hover)
Lighter color is the "active" and the darker color is the hover.
Also darkened the logo to match the color of the footer. I do think that's better.
The dropdown menus don't have top borders on their DocCSS or DoneJS. If it looks unfinished or in error to you maybe we should fix it in both places. And I decided to take the external link icon out altogether, it's a hassle and those links aren't opening in a new window as the icon usually implies, so they aren't very useful.
@lkodai these changes look great. I see a few small things I can note for later.
We need to add Quickstart to the dropdown so it's consistent:
Also, imo the content area is not wide enough in most cases. So much that the header demo isn't horizontal.
Anyway, it has potential to never end so at some point we'll just have to stop, push it to production, and then push small changes as we have time.
@lkodai thanks so much for all of the updates! Yes, I agree, we should move forward with what we have and then open smaller PR's to tackle pending items.
Great job on this! :shipit: !
Got Justin approval, going to merge this and open new issues for the little stuff mentioned above that wasn't addressed so we can track them on our EC board.
👯👯🍻🎉🍻👯👯