bitovi / documentcss

A documentation/guide portal for the Live Style Guide feature of DocumentJS
https://documentcss.com/
MIT License
72 stars 7 forks source link

Donejs theming! #24

Closed lkodai closed 8 years ago

lkodai commented 8 years ago
screen shot 2016-05-10 at 10 58 59 am

👯👯🍻🎉🍻👯👯

adrifolio commented 8 years ago

@lkodai this looks great!

Here's some things that I spotted:

<img width="591" alt="screen shot 2016-05-13 at 8 58 32 am" src="https://cloud.githubusercontent.com/assets

For example:

screen shot 2016-05-13 at 9 17 03 am
adrifolio commented 8 years ago

@lkodai one more that I spotted.

screen shot 2016-05-19 at 7 07 36 pm

But I'm wondering if we should just point to examples/styles/variables.less.html instead, as we do on the homepage CTA. Thoughts?

lkodai commented 8 years ago

Hey Adri,

Phew! So I'm leaving any demo fixes for another branch and there are enough working demos to serve purposes for now I think. This PR is already a gigantic change-storm afterall. But I went through your other comments for the better:

screen shot 2016-06-07 at 11 00 13 am

New H3 and H4 don't look like giant links anymore. (And main content links have an underline on hover)


screen shot 2016-06-07 at 11 32 16 am

Lighter color is the "active" and the darker color is the hover.


screen shot 2016-06-07 at 2 47 26 pm

Also darkened the logo to match the color of the footer. I do think that's better.


The dropdown menus don't have top borders on their DocCSS or DoneJS. If it looks unfinished or in error to you maybe we should fix it in both places. And I decided to take the external link icon out altogether, it's a hassle and those links aren't opening in a new window as the icon usually implies, so they aren't very useful.

tomgreever commented 8 years ago

@lkodai these changes look great. I see a few small things I can note for later.

We need to add Quickstart to the dropdown so it's consistent: screen shot 2016-06-08 at 8 41 57 am

Also, imo the content area is not wide enough in most cases. So much that the header demo isn't horizontal. screen shot 2016-06-08 at 8 43 59 am

Anyway, it has potential to never end so at some point we'll just have to stop, push it to production, and then push small changes as we have time.

adrifolio commented 8 years ago

@lkodai thanks so much for all of the updates! Yes, I agree, we should move forward with what we have and then open smaller PR's to tackle pending items.

Great job on this! :shipit: !

lkodai commented 8 years ago

Got Justin approval, going to merge this and open new issues for the little stuff mentioned above that wasn't addressed so we can track them on our EC board.