search

bitovi / documentjs

The sophisticated documentation engine
https://documentjs.com/
MIT License
598 stars 382 forks source link

Upgrade to steal-tools @ 0.16.6 #270

Closed pmgmendes closed 6 years ago

pmgmendes commented 7 years ago

Would it possible to upgrade documentjs to steal-tools @ 0.16.6? This is the first steal-tools version where source-map git repo dependency was replaced by bitovi-source-map package available at the public npm registry. My current issue with that our CI infrastruture "usually" doesn't has access to the public internet making it difficult to resolve transitive dependencies that need to be fetch at e.g. GitHub.

justinbmeyer commented 7 years ago

Yeah, that would be great.

Sent from my iPhone

On Apr 16, 2017, at 7:56 AM, Pedro Mendes notifications@github.com wrote:

Would it possible to upgrade documentjs to steal-tools @ 0.16.6? This is the first steal-tools version where source-map git repo dependency was replaced by bitovi-source-map package available at the public npm registry. My current issue with that our CI infrastruture "usually" doesn't has no access to the public internet making it difficult to resolve transitive dependencies that need to be fetch at e.g. GitHub.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

pmgmendes commented 7 years ago

I've forked documenjs to check the impact of the requested change - https://github.com/pmgmendes/documentjs/commit/a0ea9188e6f58e1ec151956a41d19b3eb15c8a0a. I'm unable to do a local build due an unrelated issue so I've set up a build in Travis and the outcome its pretty much the same as current documentjs master, green for node 0.10 and 0.12, red for latest node - https://travis-ci.org/pmgmendes/documentjs/builds/222758343.

How should I proceed to make this change available?

justinbmeyer commented 7 years ago

@pmgmendes just make a pull request. Thanks!