bitovi / documentjs

The sophisticated documentation engine
https://documentjs.com/
MIT License
598 stars 381 forks source link

Error with @demo tag after updating to 0.5.2 #287

Closed kylegifford closed 5 years ago

kylegifford commented 6 years ago

I upgraded an existing DocJS site from 0.4.4 to 0.5.2. On a page with the @demo tag, I get the following error. This does not happen on 0.4.4.

screenshot 2018-06-18 16 21 13 screenshot 2018-06-18 16 44 28

tracer99 commented 6 years ago

I was looking at this myself as well. If you check out the project, two tests are failing

1) documentjs/lib/generators/html can push out dev mode static:

2) documentjs/lib/generators/html "after each" hook for "body is rendered as a mustache template prior to markdown":

Don't know if related.

Eruedraith commented 6 years ago

I'm running into the same issue, does anyone have a fix on this yet?

tracer99 commented 6 years ago

@Eruedraith only a workaround. We're putting int @iframe tags for now until this gets fixed.

Eruedraith commented 6 years ago

Thanks for the quick response @tracer99 You are putting this into the stylesheet? @iframe @demo /demos/typography.html

tracer99 commented 6 years ago

not exactly @iframe /demos/typography.html

then at some point, if it gets fixed, just do a search and replace for @iframe and replace with @demo

Eruedraith commented 6 years ago

Okay that's what I figured, thank you. So for the DocumentCSS portion, there won't be any tabs for now then?

Thanks for the patience, sorry this is the first time working with Documentjs.

tracer99 commented 6 years ago

Yeah, not ideal, but it works. For small global styles, we're adding the following above the @iframe tag

* ```html
* <button class='largeBtn'></button>
* ```

Where the HTML is cut and paste from the demo.

Eruedraith commented 6 years ago

Thanks so much @tracer99! I appreciate the workaround. I'm looking forward to trying out the @demo when it's fixed. :)

johnnylord commented 5 years ago

It has been awhile : (. I'm still waiting for the bug fixed.

m-mujica commented 5 years ago

hey guys sorry for the looong delay to gets this fixed. I just published 0.5.5 and it should take care of this error. Please let me know if it works for you.