search

bitovi / documentjs

The sophisticated documentation engine
https://documentjs.com/
MIT License
598 stars 382 forks source link

Remove custom steal build setup #290

Closed m-mujica closed 6 years ago

m-mujica commented 6 years ago

This is a commit on top of #288

I proposed some changes to remove the custom build setup and since I had the changes locally I just decided to push them https://github.com/bitovi/documentjs/pull/288#issuecomment-399534774

My changes https://github.com/bitovi/documentjs/pull/290/commits/fda0f8a3cc0f4c9fa56cf7460908121c94b4199a

screen shot 2018-06-26 at 8 32 12 pm
m-mujica commented 6 years ago

There is something weird going on with this build, the npm name should be used in dist/bundles and for some reason it isn't... I think static/build might be using a different package.json.

m-mujica commented 6 years ago

hmm so @matthewp not sure why i didn't notice before but if main is provided like:

stealTools.build({ main: "index" }, {})

The bundles are written out to dist/bundles/* but if I run it like:

stealTools.build({ config: path.join(__dirname, "package.json!npm") }, {});

or 

stealTools.build({}, {})

the bundles are written out to dist/bundles/{appName}/*.

Since the name I used in the auto-generated package.json is really not significant, I would actually prefer to avoid using it in the build output.

:shipit: :trollface: