search

bitovi / funcunit

A functional test suite based on jQuery
https://funcunit.com/
MIT License
569 stars 378 forks source link

Auto update version number on home page #193

Closed rlin415 closed 7 years ago

rlin415 commented 7 years ago

Definitely need a review. This closes #192

chasenlehara commented 7 years ago

Hi @Rlin415, please make sure you write good commit messages that include a reference to the original issue and an explanation of the change. In general, you should be able to use your commit message(s) as a basis for providing a thorough PR description of the change you’re proposing.

You might consider amending the commit message and force pushing this branch.

rlin415 commented 7 years ago

@chasenlehara Sure. So what I did was basically add a template and helper function named getVersion for the home page. This was necessary because now we can dynamically generate the html for the home page when we do npm run document which allows us to update the version number accordingly each time. The generated html file for the home page is called index.html and is placed in the root directory as well so I could see why you got confused. It looks like I just hard coded the version number in, but it was in fact the generated html file for the home page after running npm run document. I put the index.html file in the .gitignore but it wasn't ignored :(