search

bitovi / funcunit

A functional test suite based on jQuery
https://funcunit.com/
MIT License
569 stars 378 forks source link

Make func unit work with Qunit 2 #205

Closed shayaneumar closed 7 years ago

shayaneumar commented 7 years ago

@matthewp need ur input on this.

matthewp commented 7 years ago

Looks good to me. Just need to update the qunit 2 package?

shayaneumar commented 7 years ago

@matthewp yes, just publish the steal_qunit2 which works with qunit2.

shayaneumar commented 7 years ago

@matthewp I waiting for package to be published so that I can proceed further.

shayaneumar commented 7 years ago

@matthewp, I am waiting on publishing.

matthewp commented 7 years ago

Which package are you waiting to be published?

shayaneumar commented 7 years ago

I have created a fork of steal–qunit which works with qunit 2 and gave it a name steal-qunit2. PR here works fine with that. I could not get my code changes working with steal-qunit1 which you earlier published. I am not sure what is the issue. can you publish a new package steal-qunit2 which works with qunit2?

matthewp commented 7 years ago

Sure.

matthewp commented 7 years ago

steal-qunit2 was published

shayaneumar commented 7 years ago

@matthewp update PR with reference of new package steal_qunit2, please take a look.

matthewp commented 7 years ago

Cool. The title still says Don't Merge, is this mergable now? :D

shayaneumar commented 7 years ago

@matthewp title is changed we can merge it now. 😀