search

bitovi / funcunit

A functional test suite based on jQuery
https://funcunit.com/
MIT License
569 stars 379 forks source link

dist folder not included on npm #220

Closed chasenlehara closed 6 years ago

chasenlehara commented 6 years ago

I just tried republishing but it didn’t include the dist folder. Nothing obvious sticks out to me as to why it’s not being published.

mckenna commented 6 years ago

I'd love to help with this. Currently blocked from upgrading from v3.0.0 (the last version to include dist/ in source). The preversion script should be run via the npm lifecycle hooks.

I don't have a tonne of experience working with npm, but I cloned the repository and published funcunit to my own namespace to see what happens. When I published, I noticed that the preversion script never ran. Do you have any visibility on whether this script runs for you on publish?

chasenlehara commented 6 years ago

Thanks for the help @mckenna, it’s really appreciated!

preversionshould definitely run; I thought I did when I tried republishing last week.

I’ve been looking at can-param for reference because it does publish dist correctly. These npm scripts look the same to me as what FuncUnit has, but I just noticed that the repo has a .npmignore file and this FuncUnit repo doesn’t.

Would you mind adding that file to your test repo and republishing? If it works and you could submit a PR, I can get it merged and released today.

mckenna commented 6 years ago

Good call. I added the .npmignore file to my test repo and when I deployed it, the dist/ folder was included. I've submitted a PR to include it.

chasenlehara commented 6 years ago

Just published v3.4.4 with your fix. Thank you @mckenna!