bitovi / launchpad

NodeJS Browser Launcher
MIT License
46 stars 28 forks source link

force to kill instance on windows #108

Open pYr0x opened 5 years ago

pYr0x commented 5 years ago

i would recommend to force the killing process and use the PID https://github.com/bitovi/launchpad/blob/master/lib/local/instance.js#L90 should be: command = 'taskkill /f /pid ' + this.id;

on my windows machine the taskkill was not working an node will not exit because a chrome will still exists