Finding Edge Fails when Edge DevTools are enabled

[zevisert]

When windows getEdgeDirectory runs, this filter

https://github.com/bitovi/launchpad/blob/b1d254a9fe405691c7a13d0c4de8b39edff4f313/lib/local/platform/windows.js#L90-L91

results in inclusion of both these paths:

• "C:\Windows\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe"
• "C:\Windows\SystemApps\Microsoft.MicrosoftEdgeDevToolsClient_8wekyb3d8bbwe"

On my system the DevToolsClient folder comes first, so launchpad returns that path right after.

https://github.com/bitovi/launchpad/blob/b1d254a9fe405691c7a13d0c4de8b39edff4f313/lib/local/platform/windows.js#L96

The DevToolsClient folder doesn't contain a copy of MicrosoftEdge.exe so launchpad fails to detect edge on my system.

Easy fix

• Just filter again to remove paths that contain DevToolsClient
• or change the filter line 91 to have a trailing underscore (but this is more of a hack)

[chasenlehara]

Thanks for filing this issue @zevisert!

I see this function being used here: https://github.com/bitovi/launchpad/blob/b1d254a9fe405691c7a13d0c4de8b39edff4f313/lib/local/platform/windows.js#L41

I wonder if it should check for MicrosoftEdge.exe in each of the folders it gets, and then select the first one if there are multiple?