search

bitovi / launchpad

NodeJS Browser Launcher
MIT License
46 stars 28 forks source link

Firefox default location #116

Closed koalixCZ closed 4 years ago

koalixCZ commented 5 years ago

Firefox default location is C:\Program Files (x86)\Mozilla Firefox\firefox.exe, but the 64 bit version is installed in C:\Program Files\Mozilla Firefox\firefox.exe.

The solution may be to add support for next possible default location, but generally, it seems to be common to have installed more browser versions for testing purposes and in this case looks the simpliest solution to try use binary from the system path.

Found in tests of npm FuncUnit 3.7.0

koalixCZ commented 5 years ago

It seems to be a problem or enhancement for Launchpad where the following code is used in general:

var programFiles = os.arch() === "x64" ? process.env["ProgramFiles(x86)"] : process.env.ProgramFiles;
cherifGsoul commented 4 years ago

This is fixed in https://github.com/bitovi/launchpad/releases/tag/v0.7.3 cc @koalixCZ