search

bitovi / launchpad

NodeJS Browser Launcher
MIT License
47 stars 28 forks source link

AppleScript exit command as opposed to kill #24

Closed alexisabril closed 11 years ago

ekryski commented 11 years ago

@alexisabril Now no more crashed sessions :smile:?

alexisabril commented 11 years ago

Hey Eric, yeah using the osascript version of exiting causes Firefox to register the exit as a "quit" as opposed to a "crash". Safari still has an issue of keeping tabs for previous launches, however that should be resolved with a clean launch(launching Safari by holding the "shift" key). I'm not sure how to do this yet via AppleScript or "open" just yet.

This fix, coupled with the prior pull on issue #21, brings stability to Chrome/Canary and Firefox for Mac remote launches.

ekryski commented 11 years ago

Beauty. It's been a while since I've had my hands dirty in there so I'll take your word for it. Thanks man!