search

bitovi / launchpad

NodeJS Browser Launcher
MIT License
46 stars 28 forks source link

LAUNCHPAD_<browser> & LAUNCHPAD_BROWSERS env vars #52

Closed mazswojejzony closed 8 years ago

mazswojejzony commented 8 years ago

This PR is related to issue #51.

MeTaNoV commented 8 years ago

:+1:

daffl commented 8 years ago

Awesome, looks good! It is missing some docs however. If you add those to the readme I can get out a 0.5.0 right away.

mazswojejzony commented 8 years ago

Yeah, I was going to update the readme but somehow I didn't. :-) Anyway, the updated docs are now in place.

mazswojejzony commented 8 years ago

I've added an ability to define more than one default location. Existing tests cover the changes. This is also kind of internal behavior hence no docs update.

daffl commented 8 years ago

Awesome, thank you! I just published version 0.5.0. If you have another minute, an update in the changelog would also be great but the release is good to go.

mazswojejzony commented 8 years ago

I've just raised another PR with changelog update: #54. Not sure if I did it correctly git-wise though.

daffl commented 8 years ago

Yep that's great. Thank you again!