search

bitovi / launchpad

NodeJS Browser Launcher
MIT License
47 stars 28 forks source link

fix to support linux #9

Closed diramazioni closed 11 years ago

diramazioni commented 11 years ago

Hello, I've made a first fix to make the pid detection and chrome work under ubuntu.

It would be nice if firefox were opening a new tab (-new-tab) if is detected that is already running. This works and is the default behavior in chrome.

~~ Eli

daffl commented 11 years ago

Yay, first pull request, thanks! Forgot that we are using the PID check to see if the browser is already running. This won't work in Windows either.

Do you know what Firefox does if you start it with -new-tab and it isn't running yet? If it just starts up we could just add it as a default parameter.

ekryski commented 11 years ago

I can check it out tonight when I get home. Thanks for the pull request! This stuff is really hard to write tests for so if you find bugs, keep them coming.

diramazioni commented 11 years ago

indeed it works! adding --new-tab works both if firefox is running and if not. made a new commit cheers

2012/12/18 Eric notifications@github.com

I can check it out tonight when I get home. Thanks for the pull request! This stuff is really hard to write tests for so if you find bugs, keep them coming.

— Reply to this email directly or view it on GitHubhttps://github.com/ekryski/launchpad/pull/9#issuecomment-11467957.

~ Eli ~

ekryski commented 11 years ago

Ok I finally got around to reviewing this. Thanks again for the pull request. There are two problems: