search

bitovi / launchpad

NodeJS Browser Launcher
MIT License
47 stars 28 forks source link

Fixed undefined value returned by getEdgeDirectory function in Windows Server #96

Closed angulito closed 5 years ago

angulito commented 6 years ago

@ifisidro and me are developing a CI system into a Windows server machine, and Windows Server 2016 does not have Microsoft Edge installed by default, so the function getEdgeDirectory allocated into windows.js file returns undefined and after that, path.join function fails.

chasenlehara commented 6 years ago

Hi @AnguloHerrera, thanks for the PR! There are a couple of listing errors, you can see them in the Travis build: https://travis-ci.org/bitovi/launchpad/jobs/333708819

angulito commented 6 years ago

Right! I didn't see it, I will take a look and I will fix them. Thanks you!

angulito commented 6 years ago

@chasenlehara Maybe could you take a look to the latest TravisCI error? I have seen that you have some builds with the same error: "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received" Thanks a lot.

angulito commented 6 years ago

@chasenlehara Reverted, although TravisCI still has the same error...

angulito commented 6 years ago

Hi @chasenlehara, I have discovered that the Firefox browser test into Linux machines does not response to the server.once('request', ...). It means that this event never is called and the test command gives timeout. You can check it with log traces into TravisCI or removing the firefox platform for Unix platforms (only for testing it). Maybe you know how it could fix. Thanks!!

angulito commented 6 years ago

Hello @chasenlehara, any update? I don't know exactly how to solve the Firefox test problem on Linux machines, and I can not test it because I don't use Linux.

Sanyusha commented 5 years ago

Hello, Is "undefined value fix" going to be merged? Thank you!

justinbmeyer commented 5 years ago

We are having trouble with travis running the tests. @cherifGsoul Any updates?

cherifGsoul commented 5 years ago

@justinbmeyer I'm planning to work on it on Friday (After tomorrow).

Sanyusha commented 5 years ago

Hi, any updates on this? Thank you.

cherifGsoul commented 5 years ago

@angulito I opened a separeate PR https://github.com/bitovi/launchpad/pull/117