search

bitovi / syn

Standalone Synthetic Event Library
https://www.npmjs.com/package/syn
MIT License
444 stars 259 forks source link

In fixing funcunit to work for HTML5 drag and drop, we unfortunately … #158

Closed kdillon closed 6 years ago

kdillon commented 6 years ago

…broke it for jQuery drag drop. The reason for this is that HTML5 stops sending mouse events and starts sending drag events when a drag begins on a draggable object. jQuery draggables do not necessarily have the draggable attribute. So we now check for the draggable attribute and send drag events if it is draggable, and if it isn't draggable we just send mousedown, mousemoves, and mouseups (etc).

One thing that I think I've done wrong here, is that the test requires jquery-ui.js . I wanted a "pure" jQuery drag and drop to test-against (rather than on draginit. I would like to cover all usecases of jQuery, not just jQuery++). And the examples that I found all used the technique that I used in the added testpage. Unfortunately that technique requires this external ui dependency.

I suspect that we would want this to be downloaded as part of node_modules, but I don't want to add new dependencies without the approval of the rest of the group.

Thanks!

kdillon commented 6 years ago

Sorry I meant to ask for Kevin Philips as a reviewer not an assignee.

matthewp commented 6 years ago

👍

chasenlehara commented 6 years ago

When merging, I would use the “Squash and merge” option so the jQuery-UI file never gets committed into the repo.

screen shot 2017-10-31 at 12 42 36 pm
kdillon commented 6 years ago

Squash-merged and deleted the branch