Mouse button event accuracy tests

bitovi / syn

Standalone Synthetic Event Library

https://www.npmjs.com/package/syn

MIT License

444 stars 258 forks source link

Mouse button event accuracy tests #166

Closed kdillon closed 6 years ago

kdillon commented 6 years ago

Adding tests around a mousebutton event value that was set incorrectly in a previous version of syn. I have no repro on this current version, but adding the tests will be beneficial in locking it down

This test is highly extensible, so we can easily modify it to include checks for other events that we are concerned-about.

kdillon commented 6 years ago

I'm not sure what lodash is. I'm not sure how I could have broken it. Any ideas?

chasenlehara commented 6 years ago

@kdillon lodash is a utility library. Weird that it wasn’t installed; I’m re-running the builds to see if it’s a fluke. Otherwise, maybe merging in https://github.com/bitovi/syn/pull/165 and then merging master into this branch will fix things (because that other PR has package-lock.json changes).

kdillon commented 6 years ago

Great, thanks @chasenlehara ! You were right about merging the previous request. Everything passed once the previous merged