search

bitovi / syn

Standalone Synthetic Event Library
https://www.npmjs.com/package/syn
MIT License
444 stars 258 forks source link

Accuracy improvements to mouse move. #168

Closed kdillon closed 5 years ago

kdillon commented 5 years ago

There is some nuance around the dispatching of mousemove and pointermove events that seems a bit arbitrary, but we do want event accuracy to be as close as possible to human interactions. Therefore, I've changed drag.js to only dispatch mousemove events during jQuery drag and drop on PointerEvents-type browsers. This appears to correctly emulate human-user event generation. Though I'm not sure why human users do not generate all events.

I've also included in this submssion some minor housekeeping around testpages, which give us warnings that some pages are not html5 doctype. They are now.

kdillon commented 5 years ago

Job is failing due to old FireFox version (56).

Test is assuming to see Pointer Events, which were introduced in Firefox 59.

justinbmeyer commented 5 years ago

In travis.yml, the version is specified

kdillon commented 5 years ago

Passing now, in case @chasenlehara and @justinbmeyer are interested in reviewing

kdillon commented 5 years ago

No reviews. Since this is now passing, I will merge shortly. I submitted one fix to a minor typo