Closed chasenlehara closed 5 years ago
Before this, testee would not launch Firefox and I’d see the following in Terminal:
node[66636]: ../src/node_contextify.cc:633:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed. 1: 0x10003b125 node::Abort() [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 2: 0x10003a183 node::AddEnvironmentCleanupHook(v8::Isolate*, void (*)(void*), void*) [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 3: 0x100064cdd node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 4: 0x10023170f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 5: 0x1002308ab v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 6: 0x1002302c7 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/chasen/.nvm/versions/node/v10.15.0/bin/node] 7: 0x2b93d3adbe3d sh: line 1: 66635 Abort trap: 6 npm run testee
We don't usually check in package-lock.json. Is there a reason to do so in this case?
Before this, testee would not launch Firefox and I’d see the following in Terminal: