search

bitpay / bitcore-lib

A pure and powerful JavaScript Bitcoin library
https://bitcore.io/
Other
611 stars 1.03k forks source link

Bitcoin Cash Support #150

Closed magmahindenburg closed 6 years ago

magmahindenburg commented 6 years ago

Hi, is there any plans to add support for BCC to this library?

edbo commented 6 years ago

Not sure on the urgency on this task as Bitpay but seems to me we'll need to rewrite this (https://github.com/bitpay/bitcore-lib/blob/master/lib/crypto/signature.js) to meet this standard:

https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki

and then update it to allow us to set the SIGHASH_FORKID bit. Would this ever get merged into the core bitcore-lib or will this entire project need to be forked to support the change?

It's a blocker for this task as far as I can see:

https://github.com/bitpay/copay-recovery/issues/49

matiu commented 6 years ago

We are working on that now.

For the moment, it will be a fork, then we can integrate it more elegantly if make sense

we hope to finish in the next few days.

On Thu, Aug 3, 2017 at 2:19 PM, Ed Bosher notifications@github.com wrote:

Not sure on the urgency on this task as Bitpay but seems to me we'll need to rewrite this (https://github.com/bitpay/bitcore-lib/blob/master/lib/ crypto/signature.js) to meet this standard:

https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki

and then update it to allow us to set the SIGHASH_FORKID bit. Would this ever get merged into the core bitcore-lib or will this entire project need to be forked to support the change?

It's a blocker for this task as far as I can see:

bitpay/copay-recovery#49 https://github.com/bitpay/copay-recovery/issues/49

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitpay/bitcore-lib/issues/150#issuecomment-320034285, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHBch6Qd4N5Z5VWVd5xS9me-Pvyflks5sUgEagaJpZM4Omeia .

-- BitPay.com

edbo commented 6 years ago

Do you have a branch already? It's something I'll be working on too.

aprz43 commented 6 years ago

Hey Guys, is there a branch with this functionality somewhere by any chance?

matiu commented 6 years ago

Yes. Check 'cash' branch at github. It is still Beta. Dont use it for production apps yet.

On Aug 9, 2017 22:36, "Adrian Przelozny" notifications@github.com wrote:

Hey Guys, is there a branch with this functionality somewhere by any chance?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitpay/bitcore-lib/issues/150#issuecomment-321426070, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHKskOU8_VM4QzwivlmfqRhunFqQZks5sWl6SgaJpZM4Omeia .

ghost commented 6 years ago

@matiu is there a 'cash' instance running somewhere to point a Copay wallet to it?

matiu commented 6 years ago

@i1o no, Copay cash's support needs more work than just this.

We will be deploying support for BCH in our Copay recovery tool https://github.com/bitpay/copay-recovery in the new few days, so you will be able to access your BCH in Copay (single or multisig).

matiu commented 6 years ago

Closed, please see: https://github.com/bitpay/bitcore-lib/tree/cash

moeadham commented 6 years ago

Anyone happen to know of a synced Insight API (or similar) instance we can get BCH Spendables from?