search

bitpay / bitcore-lib

A pure and powerful JavaScript Bitcoin library
https://bitcore.io/
Other
611 stars 1.03k forks source link

Cash #160

Closed matiu closed 6 years ago

matiu commented 6 years ago

change address version to 28/40 + fix tests

nitsujlangston commented 6 years ago

Do we want to have bitcore-cash-lib? Would it make more sense to have bitcoin cash added as additional networks with version differences and vary based on network for anything specific to bitcoin cash? That way we could use a single bitcore-lib for both.

matiu commented 6 years ago

There are differences besides the network: sighash, segwit for example. And more differences are expect to emerge. keeping them together could lead to a lot of branching on the code and test will also be a bit more messy.

Also, adding an other network will break the current code a little: for example: new Address ('bchaddress') now fails. And the app code expect it to throw. Of we add a nework it wont fail and we will need to modify at the app level to check the network after initialization.

On Sep 13, 2017 12:58 PM, "Justin Langston" notifications@github.com wrote:

Do we want to have bitcore-cash-lib? Would it make more sense to have bitcoin cash added as additional networks with version differences and vary based on network for anything specific to bitcoin cash? That way we could use a single bitcore-lib for both.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitpay/bitcore-lib/pull/160#issuecomment-329214408, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGCHPjJUv75NTRypyAEmjzRR9gfvRDlks5sh_u8gaJpZM4PVe40 .