search

bitpay / bitcore-lib

A pure and powerful JavaScript Bitcoin library
https://bitcore.io/
Other
611 stars 1.03k forks source link

Updating cash network magic to match ABC #194

Closed micahriggan closed 6 years ago

micahriggan commented 6 years ago

Closes https://github.com/bitpay/bitcore-lib/issues/193

Checked peer connections, and all of the networkMagic numbers in bitcore-lib/cash were referencing the diskMagic numbers.

This is breaking p2p for Bitcoin ABC version v0.16.2.0, this PR should fix p2p.

matiu commented 6 years ago

Thanks! ACK. Checked against: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/chainparams.cpp;2c81a03ad212b73ca7002ef9f9f891a025c1f6bd$158