isValid() / toCashAddr() Testnet support - Githubissues

bitpay / bitcore-lib

A pure and powerful JavaScript Bitcoin library

https://bitcore.io/

Other

613 stars 1.03k forks source link

isValid() / toCashAddr() Testnet support #200

Closed micahriggan closed 6 years ago

micahriggan commented 6 years ago

There were a few bugs with isValid(12345, 'regtest')

returned false for regtest addresses after enableRegtest() was called
- due to the testnet being selected as the network
- then the comparison was checking the entire object instead of the prefix
- since the network.name === 'testnet' the object compare returned false, since regtest was passed in.

There were a few bugs with toCashAddress() on testnet addresses.

concat on undefined due to testnet not having a prefixArray
normally prefixArray is added when addNetwork is called but only if prefix is defined
my previous refactor removed prefix for testnet and defined a dynamic property that toggles with enableRegtest()
my prev refactor didn't define a dynamic property for prefixArray

Added tests for these scenarios