Closed micahriggan closed 6 years ago
Before Changes
Benchmarking Script --------------------------------------- isPublicKeyHashIn x 42,112,577 ops/sec ±2.14% (421 runs sampled) isPublicKeyOut x 30,459,210 ops/sec ±2.80% (430 runs sampled) toAddress x 65,897 ops/sec ±3.15% (323 runs sampled) getAddressInfo x 86,997 ops/sec ±2.68% (325 runs sampled) Done ---------------------------------------------------------------------- Finished
After Changes
Benchmarking Script --------------------------------------- isPublicKeyHashIn x 65,906,640 ops/sec ±0.98% (516 runs sampled) isPublicKeyOut x 51,775,114 ops/sec ±0.92% (510 runs sampled) toAddress x 122,002 ops/sec ±1.03% (437 runs sampled) getAddressInfo x 143,790 ops/sec ±0.93% (528 runs sampled) Done ---------------------------------------------------------------------- Finished
There is a failing test at: https://travis-ci.org/bitpay/bitcore-lib/builds/340632730#L1213
Could you check it?
Before Changes
After Changes