search

bitpay / bitcore-message

Bitcoin Message Verification and Signing for Bitcore
88 stars 243 forks source link

[REQ] Add Segwit Sign/Verify support #30

Open brianddk opened 6 years ago

brianddk commented 6 years ago

Bitcoin issue 10542 discusses how to expand the current sign/verify functionality to include Segwit.

The basic idea is to expand the header byte to help identify the segwit address scheme

35-38 p2sh segwit pubkey (base58) 39-42 segwit pubkey (bech32)

The Trezor FW has already implemented this in commit b5f9a5

As bitcoin core is likely to implement this and Trezor already has, it would be useful to have it implemented in a block explorer too.

EvilJordan commented 6 years ago

Looks like you were wrong about bitcoin core being likely to implement. They don't seem to care.