search

bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
155 stars 212 forks source link

JS type annotations on Mnemonic don't make sense (copied from Address?) #14

Closed dskloet closed 9 years ago

dskloet commented 9 years ago

The JS doc above Mnemonic says

 * @param {*} data - The encoded data in various formats
 * @param {Network|String|number} [network] - The network: 'livenet' or 'testnet'
 * @param {String} [type] - The type of address: 'script' or 'pubkey'
 * @returns {Address} A new valid and frozen instance of an Address

This has nothing to do with Mnemonic.

https://github.com/bitpay/bitcore-mnemonic/blob/master/lib/mnemonic.js#L27

maraoz commented 9 years ago

ACK

fanatid commented 9 years ago

Mnemonic.toHDPrivateKey also have wrong JS doc..