search

bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
155 stars 212 forks source link

[Ready for testing] Fix validation to look for any wordlist with a valid checksum #36

Open dabura667 opened 8 years ago

dabura667 commented 8 years ago

Fixes https://github.com/bitpay/copay/issues/3211 and will allow for wordlists that have common words in different positions.

This fix will be especially necessary if zh_CN and zh_TW wordlists will both be supported someday, as they have many words in common.

for reference, here are 3 mnemonics only using the common words between English and French. This will help in testing.

English check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon angle
French check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon brave
both check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon amateur double
maraoz commented 8 years ago

Interesting find!

dabura667 commented 8 years ago

Ready for testing / merge if all is fine.

dabura667 commented 8 years ago

bump