bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
155 stars 212 forks source link

Request for traditional Chinese characters wordlist #50

Open songproducer opened 8 years ago

songproducer commented 8 years ago

Hi,

In Taiwan they use traditional Chinese characters as distinct from simplified characters.

How can I implement traditional Chinese characters for the mneomonic seed in the copay app?

I found a traditional Chinese wordlist here:

https://raw.githubusercontent.com/bitcoin/bips/master/bip-0039/chinese_traditional.txt

dabura667 commented 8 years ago

copay app

This is not the repository for Copay.

We can merge the Traditional Chinese wordlist into our mnemonic repo, but Copay can not use it due to a limitation in Copay.

We had to choose one type of Chinese, and we chose simplified.

We are aware that traditional is used in other places like Taiwan and Simplified is used in China.

Until we can fix the issue, and we get someone to translate our entire Copay app into traditional, we can not support Traditional mnemonic phrases.

Simplified Chinese support will be included in the next release.

songproducer commented 8 years ago

I'd be happy to help translate the entire Copay app into traditional Chinese, although not knowing what the limitation in Copay is, or whether it can be addressed is a major consideration.

Can you please tell me if that is a non-trivial issue?

songproducer commented 8 years ago

Simplified Chinese support will be included in the next release.

This is great!

My wife just brought up an important point I didn't think about. The current wordlist consists of single Chinese characters, as you're likely already aware - is more like an alphabet to the Chinese than words.

A better approach would be to take the English wordlist, run it through Google Translate and use that.

songproducer commented 8 years ago

Here are Chinese simplified and traditional wordlists that would better suit the purpose of mnemonics for the Chinese and Taiwanese people.

Simplified Chinese wordlist.pdf Traditional Chinese wordlist.pdf

songproducer commented 8 years ago

Actually we just realised a lot of the words need further review and translation. Will improve formatting too and update here.

dabura667 commented 8 years ago

please make any suggestions to the BIP39 Chinese wordlists here: https://github.com/bitcoin/bips

The files you want to edit are under the following folder. https://github.com/bitcoin/bips/tree/master/bip-0039

The basic requirements for the wordlist are as follows:

  1. Must have exactly 2048 words separated by a LF line break (no trailing line break at the end)
  2. Must be encoded in UTF-8 and normalized using NFKD
  3. Strongly suggested to have unique characters to a reasonable extent at the beginning of the word. (ie. English only has 26 letters, so 2048 words with a unique first letter is impossible, so English uses the first 4 letters, which are all unique. Japanese has more letters, so we use the first 3 letters. I would recommend that even if you make multi-character words, make sure the first character of every word is unique, since your possibilities for one character is MUCH higher than 2048, it shouldn't be too hard)

Also, if you have any considerations for user input and output, add them to the following:

https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md

(for instance: in Japanese, people who type using the hiragana alphabet will most likely be typing ideographic spaces, so I needed to tell developers that "be careful not to just split the string using a normal English space" One thing I could think of with Chinese is "users are not used to typing spaces, so remove all spaces before hashing the phrase" or something.)

When typing traditional Chinese on your phone or computer, what does a spacebar type? Are Taiwanese users used to typing spaces between words?

Could you type some Chinese for me so I can see what type of space it uses?