search

bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
159 stars 211 forks source link

Brazilian portuguese wordlist #52

Open eddieoz opened 8 years ago

eddieoz commented 8 years ago

Hi all,

I developed a brazilian portuguese wordlist for our projects and it could be interesting to put on main branch.

I tried to make a pull request from my working branch (feature-ptbr-wordlist), but it is not accepting under releases or master. I figured the steps from https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md but stills not sending.

Then I am attaching just the .js for your reviewing and if possible, telling me the steps to send the pull request with all working.

Best regards,

brazilian_portuguese.js.zip

dabura667 commented 8 years ago

This should be submitted to the BIP39 repo on bitcoin/bips

https://github.com/bitcoin/bips

Things you should change for the pull request:

  1. /bip-0039/bip-0039-wordlists.md should include a list of the rules you followed when creating the wordlist as well as any considerations developers must make to implement your wordlist correctly.
  2. /bip-0039/portuguese_brazil.txt should contain all 2048 words each with an LF line break ("\n") after each word to make the new line. the last word should also have an LF after it, so the txt file should be 2049 lines.

A few questions I have, as a non-portuguese speaker:

  1. I noticed there were no accent marks on any words, is that normal? If a brazilian person memorized the phrase, would they accidentally add an accent? (This may cause problems for users) If you are removing accents from words with accents, please describe how a developer should remove any accidental accents entered by a user etc.
  2. Remember, the wordlist must be NFKD normalized. Since ASCII alphabet characters are already NFKD normalized, they do not need to be changed, but if you add a accent, you must normalize before submitting the wordlist.