search

bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
155 stars 212 forks source link

move bitcore-lib to peer dependency #61

Closed Firescar96 closed 5 years ago

Firescar96 commented 6 years ago

an alternative to this pull request: https://github.com/bitpay/bitcore-lib/pull/187

Firescar96 commented 6 years ago

I just noticed this PR, which has since gone stale https://github.com/bitpay/bitcore-mnemonic/pull/26

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.225% when pulling 0d56a0f17bbc1326b3c2041c0c26aa609dd3d38b on Firescar96:master into 025d19a61fd8233c6c82ca91bce22e63c9ef94e3 on bitpay:master.

Firescar96 commented 6 years ago

@matiu do you have any comments?

Firescar96 commented 6 years ago

Bump

Firescar96 commented 6 years ago

Bump @matiu

Firescar96 commented 6 years ago

Bump @kleetus @nitsujlangston

tab00 commented 6 years ago

What is the status of this? I've just got the "More than one instance of bitcore-lib found" error.

JamesJansson commented 6 years ago

Bumping here in June. Anyone listening? This makes the explorer unusable.

Firescar96 commented 6 years ago

Bump @msalcala11 @kleetus @SonicWizard @nitsujlangston @cmgustavo @gabrielbazan7 @unusualbob @nitsujlangston

taylorjdawson commented 5 years ago

Can't use bitcore-lib with bitcore-ecies without getting Error: More than one instance of bitcore-lib found. Please for the love of everything that is good and holy merge this request. Thank you.

Firescar96 commented 5 years ago

Paging Agent @cmgustavo, Agent @Gamboster, Agent @gabrielbazan7, Agent @rastajpa, Agent @micahriggan, Agent @matiu, and Agent @ryanxcharles. Your assistance is needed.

matiu commented 5 years ago

Hi, I am very sorry this was here so long. Merging now.

Firescar96 commented 5 years ago

And Stallman looked down from on high, from upon a tower of lisp machines and stacks of Thinkpad T400s. And smiled, for the world below so moved him. The power of free software prevailed once again. For on git, no pull request can be forgotten and by the power of all that is GNU all contributions are welcome.