search

bitpay / bitcore-mnemonic

BIP39 Mnemonics implemented for Bitcore
http://bitcore.io
MIT License
155 stars 212 forks source link

Set upper limit on entropy as per revised BIP39 spec #67

Closed lacksfish closed 5 years ago

lacksfish commented 5 years ago

https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#generating-the-mnemonic

The allowed size of ENT is 128-256 bits.

The last step should not be allowed as stated in the revised BIP39 spec

var mnemonic = new Mnemonic(256, Mnemonic.Words.ENGLISH);
var seed = mnemonic.toSeed("password");
var derivedFrom512BitEntropyMnemonicWith48Words = Mnemonic.fromSeed(seed, Mnemonic.Words.ENGLISH);
lacksfish commented 5 years ago

Awesome, thanks!