include port when adding addr from seed

bitpay / bitcore-p2p

Interface to the bitcoin P2P network for bitcore

MIT License

81 stars 275 forks source link

include port when adding addr from seed #67

Closed pnagurny closed 9 years ago

pnagurny commented 9 years ago

We were having problems with nodes connecting to other nodes twice: once from the dnsSeed and once from the manually specified addrs array.

This fixes the issue, because when the addr is added from seed, the hash is computed based off both the host and port, the way it should be, preventing duplicate connections from happening.

coveralls commented 9 years ago

Coverage remained the same at 100.0% when pulling d273d927bb47f611d5ab7f29429392b494eb98fe on pnagurny:bug/dnsSeedPort into a603858c4bc7dba853112d85df974e0855290119 on bitpay:master.